Conversation
ctrombley
previously approved these changes
Oct 2, 2025
Collaborator
There was a problem hiding this comment.
Looks good, thanks @twitnithegirl! Looks like there's still a changelog conflict that needs resolved.
Contributor
Author
|
@ctrombley can you please re-approve. Fixing the merge conflict negated your approval. |
ctrombley
previously approved these changes
Oct 3, 2025
twitnithegirl
force-pushed
the
twitnithegirl/TFDN-1107-add-sort-params-for-agent-and-agent-pool
branch
from
45aec03 to
818fcbd
Compare
lafentres
previously approved these changes
Oct 7, 2025
ctrombley
previously approved these changes
Oct 7, 2025
ctrombley
previously approved these changes
Oct 8, 2025
Collaborator
ctrombley
left a comment
ctrombley
left a comment
There was a problem hiding this comment.
Looks good, thanks! Sorry for the delay getting this merged!
ctrombley
force-pushed
the
twitnithegirl/TFDN-1107-add-sort-params-for-agent-and-agent-pool
branch
from
6b6895c to
949d6da
Compare
shwetamurali
approved these changes
Oct 8, 2025
ctrombley
deleted the
twitnithegirl/TFDN-1107-add-sort-params-for-agent-and-agent-pool
branch
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A sort param was added to the agent-pool list a while back but was never added here. I am adding it now. I am also adding the recently added agent list sort option. There is an issue with the CreateAgent helper used int he agent list integration tests so I have not added an integration test for the agent sort option. There is a ticket to debug this helper in our backlog and once that ticket is in flight the test will be added. If you are not comfortable with us adding this option without a test here, let me know and I can just remove that line but I would like to at least get the agent pool option in.
External links
Here is a link to the Draft PR with the broken test helper for reference: #1193
Here is a link to the ticket for the follow up work on investigating these broken tests: https://hashicorp.atlassian.net/browse/TFDN-1240