Skip to content

IPL-9014 Support name and provider when unconventional display identifier#1277

Merged
jillirami merged 4 commits intomainfrom
jillirami/IPL-9014-tfe-registry-module-support-any-display-identifier
Feb 5, 2026
Merged

IPL-9014 Support name and provider when unconventional display identifier#1277
jillirami merged 4 commits intomainfrom
jillirami/IPL-9014-tfe-registry-module-support-any-display-identifier

Conversation

@jillirami
Copy link
Contributor

@jillirami jillirami commented Feb 2, 2026

Description

This pull request enhances support for creating Terraform registry modules from monorepos that do not follow the standard terraform-<provider>-<name> naming convention. It introduces optional fields for explicitly specifying the module name and provider, and adds comprehensive integration tests to ensure these scenarios work as expected.

Enhancements to module creation API:

  • Added optional Name and Provider fields to the RegistryModuleCreateWithVCSConnectionOptions struct, allowing users to specify these values explicitly when creating modules from monorepos or repositories with non-standard names. This is particularly useful when using the source_directory option and the repository name does not follow the expected convention.

Testing improvements:

  • Added a new integration test TestRegistryModulesCreateMonorepoNonStandardName in registry_module_integration_test.go to verify module creation with explicit Name and Provider in various monorepo scenarios, including:
    • Tag-based and branch-based module registration with non-standard repo names.
    • Deeply nested module paths.
    • Modules for different providers (e.g., azurerm, random).

Testing plan

E2E and written tests.

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

jillianne.ramirez@jillianne go-tfe % TFE_ADDRESS="https://tfcdev-.ngrok.io/" TFE_TOKEN="" TF_ACC=1 ENABLE_BETA=1 GITHUB_REGISTRY_MODULE_IDENTIFIER="jillirami/terraform-null-mod-monorepo" OAUTH_CLIENT_GITHUB_TOKEN="ghp_" go test -v -run TestRegistryModulesCreateMonorepoNonStandardName -timeout 10m
Screenshot 2026-02-03 at 11 33 52

Rollback Plan

Changes to Security Controls

@jillirami jillirami changed the title Support name and provider when display identifier unexpected IPL-9014 Support name and provider when unconventional display identifier Feb 2, 2026
@datadog-terraform-cloud-hashicorp
Copy link

datadog-terraform-cloud-hashicorp bot commented Feb 2, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 67b3b83 | Docs | Was this helpful? Give us feedback!

@jillirami jillirami force-pushed the jillirami/IPL-9014-tfe-registry-module-support-any-display-identifier branch from 2e829fa to fbbc953 Compare February 2, 2026 18:25
@jillirami jillirami force-pushed the jillirami/IPL-9014-tfe-registry-module-support-any-display-identifier branch from fbbc953 to bbbe4da Compare February 2, 2026 18:32
@jillirami jillirami marked this pull request as ready for review February 3, 2026 16:35
@jillirami jillirami requested a review from a team as a code owner February 3, 2026 16:35
@jillirami jillirami requested review from a team and hashimoon and removed request for a team February 3, 2026 16:36
@jillirami jillirami self-assigned this Feb 3, 2026
hashimoon
hashimoon previously approved these changes Feb 4, 2026
@hashimoon
Copy link
Contributor

Not sure how Atlas handles these use-cases, but I could see it being useful to also add unit tests there to ensure that the module and provider names are not transformed or standardized as they make there way through the app.

hashimoon
hashimoon previously approved these changes Feb 4, 2026
@jillirami jillirami force-pushed the jillirami/IPL-9014-tfe-registry-module-support-any-display-identifier branch from 2ea181a to aae9ce9 Compare February 4, 2026 23:10
@jillirami jillirami merged commit 6b7e577 into main Feb 5, 2026
15 checks passed
@jillirami jillirami deleted the jillirami/IPL-9014-tfe-registry-module-support-any-display-identifier branch February 5, 2026 19:59
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants