Conversation
2e829fa to
fbbc953
Compare
fbbc953 to
bbbe4da
Compare
hashimoon
previously approved these changes
Feb 4, 2026
Contributor
|
Not sure how Atlas handles these use-cases, but I could see it being useful to also add unit tests there to ensure that the module and provider names are not transformed or standardized as they make there way through the app. |
hashimoon
reviewed
Feb 4, 2026
…rt-any-display-identifier
hashimoon
previously approved these changes
Feb 4, 2026
2ea181a to
aae9ce9
Compare
…rt-any-display-identifier
hashimoon
approved these changes
Feb 5, 2026
Maed223
approved these changes
Feb 5, 2026
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances support for creating Terraform registry modules from monorepos that do not follow the standard
terraform-<provider>-<name>naming convention. It introduces optional fields for explicitly specifying the module name and provider, and adds comprehensive integration tests to ensure these scenarios work as expected.Enhancements to module creation API:
NameandProviderfields to theRegistryModuleCreateWithVCSConnectionOptionsstruct, allowing users to specify these values explicitly when creating modules from monorepos or repositories with non-standard names. This is particularly useful when using thesource_directoryoption and the repository name does not follow the expected convention.Testing improvements:
TestRegistryModulesCreateMonorepoNonStandardNameinregistry_module_integration_test.goto verify module creation with explicitNameandProviderin various monorepo scenarios, including:azurerm,random).Testing plan
E2E and written tests.
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Rollback Plan
Changes to Security Controls