Open
Conversation
add MAdd and MGet
jefferai
approved these changes
Dec 2, 2020
Member
jefferai
left a comment
There was a problem hiding this comment.
Looks good to me, going to rope one more person into reviewing.
@briankassouf can you just 👀 real quick? Mostly in case this is something you think you might have immediate uses for :-)
Member
|
A change just went in that updates how eviction is handled -- can you update this PR against it? |
briankassouf
approved these changes
Jan 26, 2021
Member
|
@bjkxt Got an approval from Brian, just looking for your changes against the new eviction code I think! |
Author
I think MAdd just takes the evictions of input keys and values to the caller. And the caller can decide how to handle these evictions. |
Member
|
Two issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update lru.go. Simple functions for many keys' operations with less mutex race.