Fix a data race, and add support for fixing another one in Serf#238
Open
Fix a data race, and add support for fixing another one in Serf#238
Conversation
The nodeMap contains pointers, so we need to hold the lock until all the field values have been read. Otherwise there is a data race because another goroutine could update the struct referenced by the pointer.
This change is being made to fix a data race in Serf and Consul. By accepting the tags to UpdateNodeMeta, we can use a lock around the local tags. Data races aside, fewer circular dependencies seems like a good direction.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to hashicorp/consul#8329
The first commit fixes a data race found by a modified serf test. The lock was not being held long enough.
The second commit should allow us to fix hashicorp/consul#9457