do not fire false ackMessage in timeout. check timeout in caller#304
Open
mbver wants to merge 1 commit intohashicorp:masterfrom
Open
do not fire false ackMessage in timeout. check timeout in caller#304mbver wants to merge 1 commit intohashicorp:masterfrom
mbver wants to merge 1 commit intohashicorp:masterfrom
Conversation
Author
|
hi @armon , could you please give a few comments on this when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firing a false ackMessage at timeout will cause additional checks for v.Complete in the caller and further complicates handling by resending false ackMessage. instead, only check the timeout in the caller where it is needed. therefore, there's no need for the field Complete in ackMessage.