Add support for group_add config with keep-groups#487
Open
raphlopez wants to merge 1 commit intohashicorp:mainfrom
Open
Add support for group_add config with keep-groups#487raphlopez wants to merge 1 commit intohashicorp:mainfrom
raphlopez wants to merge 1 commit intohashicorp:mainfrom
Conversation
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
github-project-automation
bot
moved this to Needs Triage
in Nomad - Community Issues Triage
jrasell
requested changes
Jan 19, 2026
Member
jrasell
left a comment
jrasell
left a comment
There was a problem hiding this comment.
Hi @raphlopez and thanks for raising this PR. It's looking really good, but CI is currently failing. Is this something you could look into? A changelog entry would also be required. Thanks.
Add config and special `keep-groups` handling required to support the `--group-add=group|keep-groups` equivalent from the podman CLI. The special `keep-groups` case allows users to configure the user running within the container process to inherit the groups of the host user.
raphlopez
force-pushed
the
group-add-support
branch
from
ba374d7 to
97c8253
Compare
Author
|
@jrasell thanks for the feedback! I added the changelog entry, fixed the CI failure, and implemented the suggested testing change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config and special
keep-groupshandling required to support the--group-add=group|keep-groupsequivalent from the podman CLI. The specialkeep-groupscase allows users to configure the user running within the container process to inherit the groups of the host user.Closes #390
Changes to Security Controls
Job submissions can now specify arbitrary host groups that the container user should be added to, which weakens the container isolation boundary. Main use case for this is trusted workloads that need access to host resources for e.g. telemetry collection.