fix: add registry does not honor default main/master branch#843
Open
ritesh-harihar wants to merge 2 commits intomainfrom
Open
fix: add registry does not honor default main/master branch#843ritesh-harihar wants to merge 2 commits intomainfrom
ritesh-harihar wants to merge 2 commits intomainfrom
Conversation
956701c to
fc32eba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This occurred because when users do not explicitly pass a --ref string, Nomad Pack assumed the target was "latest". For performance reasons, a previous PR introduced logic that appended ?depth=1 to the Go-Getter URL for "latest" downloads to enforce a shallow clone.
However, forcing depth=1 without specifying a branch name causes the underlying git clone mechanism inside go-getter to eagerly assume the master branch on certain repository schemas. For registries defaulting to main, this throws an error.
Fix:
This PR repairs the broken behavior by removing the hardcoded ?depth=1 parameter injection for latest registries entirely:
JIRA Ticket
Reminders
CHANGELOG.mdentryChanges to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.