Skip to content

Conversation

@schmichael
Copy link
Member

@schmichael schmichael commented Nov 22, 2025

Errors from Decode are non-recoverable and should cause Stream to return. Otherwise Stream will loop forever on EOF from Decode.

Fixes #27133

Repro: https://gist.github.com/schmichael/247a39bf36406c08c8a95fc8c85bd56a

Description

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Errors from Decode are non-recoverable and should cause Stream to
return. Otherwise Stream will loop forever on EOF from Decode.

Fixes #27133

Repro: https://gist.github.com/schmichael/247a39bf36406c08c8a95fc8c85bd56a
jrasell
jrasell previously approved these changes Nov 24, 2025
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think we will also need a changelog entry and backport labels.

@schmichael schmichael merged commit 0f2e7fd into main Jan 24, 2026
37 checks passed
@schmichael schmichael deleted the b-events-api-27117 branch January 24, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.11.x backport to 1.11.x release line theme/api HTTP API and SDK issues type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api Client EventStream; can not detect nomad server‘s disconnet,and reconnect to server automaticly

3 participants