artifact: implement findHomeDir helper as specified #27251
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
reviewed
Jan 22, 2026
Comment on lines
31
to
33
| if home, err := os.UserHomeDir(); err == nil { | ||
| return home | ||
| } |
Member
There was a problem hiding this comment.
I don't think we want this: the os.UserHomeDir function only looks at the environment, whereas homedir.Dir looks at the environment and then has some platform-specific fallback behavior. We're calling homedir.Dir() anyways, so I don't think this gets us anything and it's the docstring of the function that should be fixed instead.
Member
Author
There was a problem hiding this comment.
That's fair! I've updated the docstring and kept the path change.
This makes a couple small changes to the findHomeDir helper function to properly match the described behavior. It will attempt to use os.UserHomeDir first, and if no path can be discovered, it will return /dev/null.
chrisroberts
force-pushed
the
f-getter-util-align
branch
from
35e0048 to
6017fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes a couple small changes to the findHomeDir helper function to properly match the described behavior. It will attempt to use os.UserHomeDir first, and if no path can be discovered, it will return /dev/null.
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.