Skip to content

Remove redundant square braces for ipv6 with latest sdk version #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vin01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove redundant square braces for ipv6 with latest sdk version #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions builder/openstack/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ package openstack

import (
"errors"
"fmt"
"log"
"time"

Expand Down Expand Up @@ -90,21 +89,22 @@ func sshAddrFromPool(s *servers.Server, desired string, sshIPVersion string) str
for _, element := range elements {
var addr string
address := element.(map[string]interface{})
address_value := address["addr"].(string)
if address["OS-EXT-IPS:type"] == "floating" {
Copy link

@zadjadr zadjadr Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get rid of this entire if else workflow now

Copy link
Author

@vin01 vin01 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is needed to use the right precedence (ipv6 > ipv4) and also if explicit config option forces use of v4 or v6.

addr = address["addr"].(string)
addr = address_value
} else if sshIPVersion == "4" {
if address["version"].(float64) == 4 {
addr = address["addr"].(string)
addr = address_value
}
} else if sshIPVersion == "6" {
if address["version"].(float64) == 6 {
addr = fmt.Sprintf("[%s]", address["addr"].(string))
addr = address_value
}
} else {
if address["version"].(float64) == 6 {
addr = fmt.Sprintf("[%s]", address["addr"].(string))
addr = address_value
} else {
addr = address["addr"].(string)
addr = address_value
}
}

Expand Down