-
Notifications
You must be signed in to change notification settings - Fork 106
feat: add override option #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9cd4105 to
e34dc46
Compare
e34dc46 to
7f6a279
Compare
f29764c to
1cddfa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an override boolean option to the vsphere-template post-processor, allowing users to overwrite existing templates when set to true. By default, the option is false, maintaining backward compatibility.
Key Changes
- Added
Overridefield to the Config struct with proper documentation and HCL2 specification - Implemented template existence checking and removal logic in the mark-as-template step
- Added comprehensive test coverage for the new override functionality
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| post-processor/vsphere-template/post-processor.go | Added Override field to Config struct |
| post-processor/vsphere-template/step_mark_as_template.go | Implemented override logic with template existence checking and removal |
| post-processor/vsphere-template/step_mark_as_template_test.go | Added comprehensive test coverage for override functionality |
| post-processor/vsphere-template/post-processor_test.go | Added tests for override configuration |
| post-processor/vsphere-template/post-processor.hcl2spec.go | Added HCL2 specification for override field |
| docs-partials/post-processor/vsphere-template/Config-not-required.mdx | Updated documentation with override option |
| .web-docs/components/post-processor/vsphere-template/README.md | Updated web documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1cddfa0 to
0cab817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Adds an `override` (bool) option to the `vsphere-template` post-processor, allowing the overwrite of an existing template if set to `true`. Signed-off-by: Ryan Johnson <[email protected]>
0cab817 to
495050b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
Adds an
override(bool) option to thevsphere-templatepost-processor, allowing the overwrite of an existing template if set totrue.If
override = false(default):Resolved Issues
Closes #521
Rollback Plan
Revert commit.
Changes to Security Controls
None.