refactor: time synchronization settings #581
Merged
+101
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
added
builder/vsphere-iso
tenthirtyam
force-pushed
the
refactor/time-sync-setting
branch
3 times, most recently
from
9f63f00 to
bb6eeb9
Compare
tenthirtyam
changed the title
- Refactored `tools_sync_time` from `bool` to `*bool` in `ConfigParamsConfig` to distinguish explicit `true/false` from omission, and adjust logic to handle `nil` values. - Added `tools_sync_time_periodically` configuration option for periodic time synchronization between the guest operating system and the ESX host. Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
refactor/time-sync-setting
branch
from
bb6eeb9 to
14d4e05
Compare
There was a problem hiding this comment.
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kp2099
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored
tools_sync_timefromboolto*boolinConfigParamsConfigto distinguish explicittrue/falsefrom omission, and adjust logic to handlenilvalues. The change makestools_sync_timeoptional and clarifies its behavior when omitted, ensuring more flexible and accurate time synchronization settings for virtual machines.Added
tools_sync_time_periodicallyconfiguration option for periodic time synchronization between the guest operating system and the ESX host.Configuration and Validation Updates:
tools_sync_time_periodicallyoption to bothvsphere-isoandvsphere-clonebuilders, allowing users to enable or disable periodic time synchronization. This is only recommended if the guest OS does not have native time sync. [1] [2] [3]tools_sync_timeoption to accept a pointer (*bool), clarifying its meaning and inheritance: if omitted, the builder uses defaults or inherits from the source VM.tools_sync_time_periodicallycan only be enabled iftools_sync_timeis also set totrue.Documentation Improvements:
Internal Code Changes:
Resolved Issues
Closes #547
Closes #499
Rollback Plan
Revert commit.
Changes to Security Controls
None.