Check LASTEXITCODE is set before checking its value#13539
Merged
kp2099 merged 2 commits intohashicorp:mainfrom Jan 28, 2026
Merged
Check LASTEXITCODE is set before checking its value#13539kp2099 merged 2 commits intohashicorp:mainfrom
kp2099 merged 2 commits intohashicorp:mainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Collaborator
|
Hi @MBradbury Thank you for your contribution. This change makes sense to me. please fix the test cases as well. |
kp2099
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running the Powershell provisioner with inline commands, those inline commands may not set
LASTEXITCODE. However, the provisioner will always check the value ofLASTEXITCODE(https://github.com/hashicorp/packer/blob/main/provisioner/powershell/provisioner.go#L41).Will produce output such as the following:
This PR checks if
LASTEXITCODEhas been set before checking its value.Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
No changes to security controls.