Skip to content

Conversation

@isivaselvan
Copy link
Collaborator

Description

Refactored List method to return Iterator

Refactor involves, code modifications on list method and models of features at,

  • Reserved Tag Key
  • Oauth Token
  • Policy Evaluation
  • Policy Set Outcome
  • Removed UID attribute at oauth token, as api docs doesn't have that key response.
  • Removed Read method at Reserved Tag, as no such endpoint present in the api docs.
  • Removed page number attribute from the List options model.

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.


> python examples/reserved_tag_key.py                                                                        
Reserved Tag Keys API Example for organization: prab-sandbox01
============================================================

1. Listing reserved tag keys...
  - ID: rtk-WTjHnXqn9tMpDtKS, Key: python-tfe-example, Disable Overrides: False
  - ID: rtk-7sxBYDFR2Ponxzc7, Key: python-tfe-example1, Disable Overrides: False


> python examples/oauth_token.py     
================================================================================
OAUTH TOKEN COMPLETE TESTING SUITE
================================================================================

1. Testing list() function:
   Token ID: ot-xUxMrwCQ**
     Service Provider User: aayushsingh2502
     Has SSH Key: False
     Created: 2025-10-02 14:57:53.316000+00:00

   Using token ot-xUxMrwCQqR4rr1Kk for subsequent tests 

   Token ID: ot-QtfSNAHN**
     Service Provider User: aayushsingh2502
     Has SSH Key: False
     Created: 2025-10-02 15:00:02.702000+00:00
   Token ID: ot-gAGuPJ**
     Service Provider User: aayushsingh2502
     Has SSH Key: True
     Created: 2025-09-17 10:18:08.445000+00:00
   Token ID: ot-wiavqfzp**
     Service Provider User: aayushsingh2502
     Has SSH Key: False
     Created: 2025-10-02 14:46:08.015000+00:00
   Token ID: ot-MVgPy4S6**
     Service Provider User: aayushsingh2502
     Has SSH Key: True
     Created: 2025-10-02 14:45:43.354000+00:00
   Token ID: ot-XBtiW3M**
     Service Provider User: aayushsingh2502
     Has SSH Key: True
     Created: 2025-10-02 14:47:28.100000+00:00
   Token ID: ot-h86DPA**
     Service Provider User: aayushsingh2502
     Has SSH Key: True
     Created: 2025-10-02 14:52:12.884000+00:00
   Token ID: ot-QkrHUaA**
     Service Provider User: aayushsingh2502
     Has SSH Key: True
     Created: 2025-10-02 14:56:42.594000+00:00


> python examples/policy_evaluation.py --task-stage-id ts-pr2D9JkbqwQ*

================================================================================
Listing policy evaluations for task stage: ts-pr2D9JkbqwQ*
================================================================================
No policy evaluations found for this task stage.

Rollback Plan

Changes to Security Controls

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.

@isivaselvan isivaselvan requested a review from a team as a code owner December 18, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant