This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Updated versions, added tag variables and updated java/nomad installation#37
Open
stenio123 wants to merge 3 commits intohashicorp:masterfrom
stenio123:master
Open
Updated versions, added tag variables and updated java/nomad installation#37stenio123 wants to merge 3 commits intohashicorp:masterfrom stenio123:master
stenio123 wants to merge 3 commits intohashicorp:masterfrom
stenio123:master
Conversation
stenio123
commented
Dec 14, 2018
stenio123
commented
- Need to review Packer file for Ubuntu, Java and Docker not being installed
Added custom tags to modules
brikis98
reviewed
Dec 14, 2018
Collaborator
brikis98
left a comment
brikis98
left a comment
There was a problem hiding this comment.
Thanks for the PR!
How did you test it?
| "consul_module_version": "v0.3.1", | ||
| "consul_version": "1.0.3" | ||
| "nomad_version": "0.8.6", | ||
| "consul_module_version": "master", |
Collaborator
There was a problem hiding this comment.
We probably should use a specific tag rather than master, as we occasionally have to make backwards incompatible changes (e.g., Terraform 0.12 is coming!).
| sudo apt-get update | ||
| apt-cache policy docker-ce | ||
| # Desired Nomad drivers - Docker and Java | ||
| sudo apt install docker.io -y |
Collaborator
There was a problem hiding this comment.
apt often has very out of date versions of Docker. The original option is what the official Docker documentation recommends for Ubuntu, so we should stick with it.
|
|
||
| sudo apt-get install -y docker-ce | ||
| sudo usermod -a -G docker ubuntu | ||
| sudo apt install -y default-jdk |
Collaborator
There was a problem hiding this comment.
Why do we need to install Java?
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.