This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Add optional parameter for unauthenticated metrics access#267
Open
vgsantoniazzi wants to merge 3 commits intohashicorp:masterfrom
Open
Add optional parameter for unauthenticated metrics access#267vgsantoniazzi wants to merge 3 commits intohashicorp:masterfrom
vgsantoniazzi wants to merge 3 commits intohashicorp:masterfrom
Conversation
|
Cool! Exactly what were going to do! Thank you! |
|
Would love to see this merged as it is the last stumbling block in automating our metrics setup for vault! |
Author
|
@rcousens replaced the underscore with hyphens. Does it look good now? |
Author
|
@robmorgan can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's no way to generate unauthenticated metrics access. I've tried to use the merge config files but it seems that the "tcp" listener got overridden by the second file.
Open issue: hashicorp/vault#5860
Documentation
TODOs
Please ensure all of these TODOs are completed before asking for a review.
feature/new-vpc-endpoints-955orbug/missing-count-param-434.Related Issues