fix: use absolute URIs with terraform:// scheme for resources#274
Open
ZauberNerd wants to merge 1 commit intohashicorp:mainfrom
Open
fix: use absolute URIs with terraform:// scheme for resources#274ZauberNerd wants to merge 1 commit intohashicorp:mainfrom
ZauberNerd wants to merge 1 commit intohashicorp:mainfrom
Conversation
Resource URIs were using relative paths like `/terraform/style-guide` which don't comply with the MCP specification. RFC 3986 requires URIs to have a scheme. This changes the resource URIs to use the `terraform://` scheme: - `/terraform/style-guide` -> `terraform://guides/style-guide` - `/terraform/module-development` -> `terraform://guides/module-development` Also fixed the sub-resource URI construction for module-development which was using path.Join() that would incorrectly handle the `://` in the URI scheme.
ZauberNerd
force-pushed
the
fix/absolute-resource-uris
branch
from
7a0a918 to
b87762f
Compare
Contributor
|
@ZauberNerd Thanks for the contribution! Will look into the PR this week, and will have a review by the EOW 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource URIs were using relative paths like
/terraform/style-guidewhich don't comply with the MCP specification, which requires resource URIs to be valid URIs per RFC 3986 (i.e., must include a scheme).This changes the resource URIs to use the
terraform://scheme:/terraform/style-guide→terraform://guides/style-guide/terraform/module-development→terraform://guides/module-developmentAlso fixed the sub-resource URI construction for
module-developmentwhich was usingpath.Join()that would incorrectly handle the://in the URI scheme.PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.