add proxy-friendly headers and address locking#291
Merged
jaylonmcshan19-x merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
Contributor
|
We don't want to add TLS skip or the TFE endpoint as HTTP headers. Just supporting the token via |
jrhouston
requested changes
Mar 16, 2026
jrhouston
requested changes
Mar 18, 2026
CHANGELOG.md
Outdated
|
|
||
| IMPROVEMENTS | ||
| * Add `Authorization: Bearer` header support for Terraform token in proxy environments | ||
| * Add `MCP_LOCK_TFE_ADDRESS` env var to prevent clients from overriding the TFE address when hosting MCP server centrally |
Contributor
There was a problem hiding this comment.
This isn't in the PR, remove this line.
jrhouston
approved these changes
Mar 26, 2026
jaylonmcshan19-x
force-pushed
the
fix/nginx-underscore-headers
branch
from
da40ce0 to
78c20ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCI review checklist
This PR fixes #267 - TFE_TOKEN is rejected as header if MCP server is hosted behind nginx
This PR Adds adds support for supplying the Token via Authorization header:
Authorization: Bearer <token>(standard HTTP auth)If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.