Skip to content

Conversation

@SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Feb 26, 2025

  • Replace max-per-linter with max-issues-per-linters
  • Replace exportloopref linter with copyloopvar
  • Replace tenv linter with usetesting

@SBGoods SBGoods requested a review from a team as a code owner February 26, 2025 16:44
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (one observation, no action needed imo)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you meant to do this explicitly, although it doesn't really matter since this is a binary 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess my IDE automatically upgraded the toolchain 😆

@SBGoods SBGoods merged commit e7650fa into main Feb 26, 2025
3 checks passed
@SBGoods SBGoods deleted the SBGoods/linting-fixes branch February 26, 2025 23:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants