listresourcevalidator: add new package with common validators for list resource configurations #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephybun
commented
Jul 21, 2025
Comment on lines
+42
to
+54
| func (v AtLeastOneOfValidator) ValidateEphemeralResource(ctx context.Context, req ephemeral.ValidateConfigRequest, resp *ephemeral.ValidateConfigResponse) { | ||
| resp.Diagnostics = v.Validate(ctx, req.Config) | ||
| } | ||
|
|
||
| func (v AtLeastOneOfValidator) ValidateResource(ctx context.Context, req resource.ValidateConfigRequest, resp *resource.ValidateConfigResponse) { | ||
| func (v AtLeastOneOfValidator) ValidateListResourceConfig(ctx context.Context, req list.ValidateConfigRequest, resp *list.ValidateConfigResponse) { | ||
| resp.Diagnostics = v.Validate(ctx, req.Config) | ||
| } | ||
|
|
||
| func (v AtLeastOneOfValidator) ValidateEphemeralResource(ctx context.Context, req ephemeral.ValidateConfigRequest, resp *ephemeral.ValidateConfigResponse) { | ||
| func (v AtLeastOneOfValidator) ValidateProvider(ctx context.Context, req provider.ValidateConfigRequest, resp *provider.ValidateConfigResponse) { | ||
| resp.Diagnostics = v.Validate(ctx, req.Config) | ||
| } | ||
|
|
||
| func (v AtLeastOneOfValidator) ValidateResource(ctx context.Context, req resource.ValidateConfigRequest, resp *resource.ValidateConfigResponse) { |
Member
Author
There was a problem hiding this comment.
Performed some alphabetical reordering in several files similar to this..
stephybun
changed the title
rainkwan
approved these changes
Jul 22, 2025
rainkwan
left a comment
rainkwan
left a comment
There was a problem hiding this comment.
Everything seems reasonable to me, I also feel the urge to reorder for alphabetical order sometimes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Dependent on hashicorp/terraform-plugin-framework#1178
Description
Adds validators for List Resource Configs.
Rollback Plan
Changes to Security Controls
None.