-
Notifications
You must be signed in to change notification settings - Fork 99
ephemeral: Initial ephemeral resource type implementation #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [github.com/hashicorp/terraform-plugin-go](https://github.com/hashicorp/terraform-plugin-go) from 0.24.0 to 0.25.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-go/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-go/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-go@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
SBGoods
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments on documentation but otherwise LGTM!
|
|
||
| Implement the `Close` method by: | ||
|
|
||
| 1. [Accessing private data](/terraform/plugin/framework/resources/private-state#reading-private-state-data) from [`ephemeral.CloseRequest.Private` field](https://pkg.go.dev/github.com/hashicorp/terraform-plugin-framework/ephemeral#CloseRequest.Private) needed to close the remote object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create a separate page for ephemeral resource private data instead of reusing the managed resource page? We can also just leave a todo for this and add it when ephemeral resources goes GA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we should either make this page more generic and move it, or just duplicate it. I just opted to delay that for now since it gets the general information across. I think we can come back and adjust it later 👍🏻
website/docs/plugin/framework/ephemeral-resources/validate-configuration.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Selena Goods <[email protected]>
…figuration.mdx Co-authored-by: Selena Goods <[email protected]>
The next versions of the plugin protocol (5.7/6.7) include support for a new "ephemeral resource" type
This is an initial implementation of that support with:
ephemeralpackage with all exported Go types for provider developers to implement ephemeral resources.ephemeral/schemapackage with matching attribute schema support to the other schema supporting concepts (data sources, provider, and managed resources)ValidateEphemeralResourceConfig,OpenEphemeralResource,RenewEphemeralResource, andCloseEphemeralResourceRPCs in the internal framework server, proto5/6 servers, and data handling between all layersGetProviderSchemaandGetMetadataRPCsThis functionality will be released as technical preview without compatibility promises until Terraform 1.10 is generally available. Go and website documentation include additional callouts about the compatibility of this functionality.