Skip to content

chore: Update golangci-lint linters and apply fixes #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

chore: Update golangci-lint linters and apply fixes #1091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 4 additions & 4 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
issues:
max-per-linter: 0
max-issues-per-linter: 0
max-same-issues: 0

linters:
disable-all: true
enable:
- copyloopvar
- durationcheck
- errcheck
- exportloopref
- forcetypeassert
- gofmt
- gosimple
- govet
- ineffassign
- makezero
- misspell
- nilerr
- paralleltest
- predeclared
- staticcheck
- tenv
- unconvert
- unparam
- unused
- govet
- usetesting

run:
# Prevent false positive timeouts in CI
Expand Down
24 changes: 0 additions & 24 deletions datasource/schema/bool_attribute_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ func TestBoolAttributeApplyTerraform5AttributePathStep(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -104,8 +102,6 @@ func TestBoolAttributeBoolValidators(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -138,8 +134,6 @@ func TestBoolAttributeGetDeprecationMessage(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -173,8 +167,6 @@ func TestBoolAttributeEqual(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -207,8 +199,6 @@ func TestBoolAttributeGetDescription(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -241,8 +231,6 @@ func TestBoolAttributeGetMarkdownDescription(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -275,8 +263,6 @@ func TestBoolAttributeGetType(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -309,8 +295,6 @@ func TestBoolAttributeIsComputed(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -343,8 +327,6 @@ func TestBoolAttributeIsOptional(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -377,8 +359,6 @@ func TestBoolAttributeIsRequired(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -411,8 +391,6 @@ func TestBoolAttributeIsSensitive(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand All @@ -439,8 +417,6 @@ func TestBoolAttributeIsWriteOnly(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down
24 changes: 0 additions & 24 deletions datasource/schema/dynamic_attribute_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ func TestDynamicAttributeApplyTerraform5AttributePathStep(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -104,8 +102,6 @@ func TestDynamicAttributeGetDeprecationMessage(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -139,8 +135,6 @@ func TestDynamicAttributeEqual(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -173,8 +167,6 @@ func TestDynamicAttributeGetDescription(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -207,8 +199,6 @@ func TestDynamicAttributeGetMarkdownDescription(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -241,8 +231,6 @@ func TestDynamicAttributeGetType(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -275,8 +263,6 @@ func TestDynamicAttributeIsComputed(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -309,8 +295,6 @@ func TestDynamicAttributeIsOptional(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -343,8 +327,6 @@ func TestDynamicAttributeIsRequired(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -377,8 +359,6 @@ func TestDynamicAttributeIsSensitive(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand All @@ -405,8 +385,6 @@ func TestDynamicAttributeIsWriteOnly(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -439,8 +417,6 @@ func TestDynamicAttributeDynamicValidators(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down
24 changes: 0 additions & 24 deletions datasource/schema/float32_attribute_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ func TestFloat32AttributeApplyTerraform5AttributePathStep(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -104,8 +102,6 @@ func TestFloat32AttributeFloat32Validators(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -138,8 +134,6 @@ func TestFloat32AttributeGetDeprecationMessage(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -173,8 +167,6 @@ func TestFloat32AttributeEqual(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -207,8 +199,6 @@ func TestFloat32AttributeGetDescription(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -241,8 +231,6 @@ func TestFloat32AttributeGetMarkdownDescription(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -275,8 +263,6 @@ func TestFloat32AttributeGetType(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -309,8 +295,6 @@ func TestFloat32AttributeIsComputed(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -343,8 +327,6 @@ func TestFloat32AttributeIsOptional(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -377,8 +359,6 @@ func TestFloat32AttributeIsRequired(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -411,8 +391,6 @@ func TestFloat32AttributeIsSensitive(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand All @@ -439,8 +417,6 @@ func TestFloat32AttributeIsWriteOnly(t *testing.T) {
}

for name, testCase := range testCases {
name, testCase := name, testCase

t.Run(name, func(t *testing.T) {
t.Parallel()

Expand Down
Loading
Loading