list: tidy the doc comments and tests #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbasata
force-pushed
the
revisit-list-package
branch
from
4f2a577 to
d07f61a
Compare
bbasata
commented
Jun 16, 2025
| "github.com/hashicorp/terraform-plugin-framework/resource/schema/defaults" | ||
| "github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier" | ||
| "github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault" | ||
| listschema "github.com/hashicorp/terraform-plugin-framework/list/schema" |
Contributor
Author
There was a problem hiding this comment.
💭 When writing providers for testing, I've needed to name imports like this fairly often. Especially when using list/schema and resource/schema in the same file, which is common.
So this test merged with the wrong imports 🙃
If consistency was not an issue, I might have the package live at github.com/hashicorp/terraform-plugin-framework/listschema to make things easier to work with.
For the moment, it seems practical to leave this as it is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
listpackage.ListResultsStream, based on discussion with Core team today.Validatemethod.list/schema/string_attribute_test.goRollback Plan
Changes to Security Controls
None