Add statecheck.ExpectIdentityValue for asserting resource identity values
#468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
commented
Mar 25, 2025
austinvalle
commented
Mar 25, 2025
Comment on lines
+123
to
+124
| // TODO: This should be replaced by the `ValueType` method from plugin-go: | ||
| // https://github.com/hashicorp/terraform-plugin-go/pull/497 |
Member
Author
There was a problem hiding this comment.
hashicorp/terraform-plugin-go#497 will let us resolve this in a follow-up PR
austinvalle
commented
Mar 25, 2025
Comment on lines
+152
to
+153
| // TODO: This should be replaced by the `ValueType` method from plugin-go: | ||
| // https://github.com/hashicorp/terraform-plugin-go/pull/497 |
Member
Author
There was a problem hiding this comment.
hashicorp/terraform-plugin-go#497 will let us resolve this in a follow-up PR
bbasata
previously approved these changes
Mar 25, 2025
Collaborator
bbasata
left a comment
bbasata
left a comment
There was a problem hiding this comment.
One suggestion in line comments.
Co-authored-by: Baraa Basata <[email protected]>
austinvalle
force-pushed
the
av/resource-identity-checks
branch
from
9e31baf to
4a7dff2
Compare
Member
Author
|
I'm going to merge this so we can utilize the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a couple changes:
internal/testing/testproviderand SDKUpgradeResourceIdentityRPC, which we only need to implement if we plan on testing it in this repo, which I'm not 100% sure we need to.tfversion.Version1_12_0package variable