helper/resource: refine config-building for plannable import tests #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows explict inline Terraform configuration in an `ImportState` test step. In a newly-added test, we have a scenario where it's useful to the test author to write their own import block, without resorting to `ConfigFile` or `ConfigDirectory`. This change also adds a test to cover the use of external providers with plannable import tests.
austinvalle
approved these changes
Apr 15, 2025
| { | ||
| ImportState: true, | ||
| ImportStateKind: r.ImportBlockWithID, | ||
| Config: configWithImportBlock, |
Member
There was a problem hiding this comment.
Just to confirm my understanding, provider developers wouldn't need to use a config in this scenario to do this (if the ID needing to be explicitly defined), they could just use ImportStateId:
{
ImportState: true,
ImportStateKind: r.ImportBlockWithID,
ImportStateId: "It was a dark and stormy night.",
ResourceName: "random_string.mystery_message",
ImportPlanChecks: r.ImportPlanChecks{
PreApply: []plancheck.PlanCheck{
plancheck.ExpectKnownValue(
"random_string.mystery_message",
tfjsonpath.New("result"),
knownvalue.StringExact("It was a dark and stormy night.")),
},
},
},
Collaborator
Author
There was a problem hiding this comment.
ImportStateId
Nice catch. We could come up with a different example here so that it better models a situation that calls for an inline config.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows explict inline Terraform configuration in an
ImportStatetest step. In a newly-added test, we have a scenario where it's useful to the test author to write their own import block, without resorting toConfigFileorConfigDirectory.This change also adds a test to cover the use of external providers with plannable import tests.