Skip to content

echoprovider: Fix bug where Terraform v1.12.1 would return an error indicating GetResourceIdentitySchemas was not implemented #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

echoprovider: Fix bug where Terraform v1.12.1 would return an error indicating GetResourceIdentitySchemas was not implemented #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18f8d55
implement resource identity schema + changelogs
austinvalle May 21, 2025
bbf5f63
update plugin-testing
austinvalle May 21, 2025
f020695
revert plugin-go
austinvalle May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/unreleased/BUG FIXES-20250521-152657.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
kind: BUG FIXES
body: 'echoprovider: Fixed bug where Terraform v1.12+ would return an error message indicating the provider doesn''t support `GetResourceIdentitySchemas`.'
time: 2025-05-21T15:26:57.058404-04:00
custom:
Issue: "512"
16 changes: 16 additions & 0 deletions echoprovider/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,3 +406,19 @@ func (e *echoProviderServer) CloseEphemeralResource(ctx context.Context, req *tf
func (e *echoProviderServer) ValidateEphemeralResourceConfig(ctx context.Context, req *tfprotov6.ValidateEphemeralResourceConfigRequest) (*tfprotov6.ValidateEphemeralResourceConfigResponse, error) {
return &tfprotov6.ValidateEphemeralResourceConfigResponse{}, nil
}

func (e *echoProviderServer) GetResourceIdentitySchemas(context.Context, *tfprotov6.GetResourceIdentitySchemasRequest) (*tfprotov6.GetResourceIdentitySchemasResponse, error) {
return &tfprotov6.GetResourceIdentitySchemasResponse{}, nil
}

func (e *echoProviderServer) UpgradeResourceIdentity(context.Context, *tfprotov6.UpgradeResourceIdentityRequest) (*tfprotov6.UpgradeResourceIdentityResponse, error) {
return &tfprotov6.UpgradeResourceIdentityResponse{
Diagnostics: []*tfprotov6.Diagnostic{
{
Severity: tfprotov6.DiagnosticSeverityError,
Summary: "Unsupported UpgradeResourceIdentity Operation",
Detail: "Resource Identity is not supported by this provider.",
},
},
}, nil
}
8 changes: 8 additions & 0 deletions internal/testing/testsdk/providerserver/providerserver_protov5.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,11 @@ func (s Protov5ProviderServer) CloseEphemeralResource(ctx context.Context, req *
func (s Protov5ProviderServer) ValidateEphemeralResourceConfig(ctx context.Context, req *tfprotov5.ValidateEphemeralResourceConfigRequest) (*tfprotov5.ValidateEphemeralResourceConfigResponse, error) {
return &tfprotov5.ValidateEphemeralResourceConfigResponse{}, nil
}

func (s Protov5ProviderServer) GetResourceIdentitySchemas(context.Context, *tfprotov5.GetResourceIdentitySchemasRequest) (*tfprotov5.GetResourceIdentitySchemasResponse, error) {
return &tfprotov5.GetResourceIdentitySchemasResponse{}, nil
}

func (s Protov5ProviderServer) UpgradeResourceIdentity(context.Context, *tfprotov5.UpgradeResourceIdentityRequest) (*tfprotov5.UpgradeResourceIdentityResponse, error) {
return &tfprotov5.UpgradeResourceIdentityResponse{}, nil
}
Loading