List Resource QueryCheck #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: stephybun <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: stephybun <[email protected]>
…r/resource running
…butes, started to add length and length exact checks
…pleteData and refactor a little
…y checks to be consistent with existing statechecks
austinvalle
previously approved these changes
Sep 17, 2025
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Looking good! Sounds like this is going to be a beta, so we can still come back and change any naming later if we so choose. All of the comments I left are nits that can be addressed/dismissed later
| // createDeltaString prints the map keys that are present in mapA and not present in mapB | ||
| func createDeltaString[T any, V any](mapA map[string]T, mapB map[string]V, msgPrefix string) string { | ||
| // CreateDeltaString prints the map keys that are present in mapA and not present in mapB | ||
| func CreateDeltaString[T any, V any](mapA map[string]T, mapB map[string]V, msgPrefix string) string { |
Member
There was a problem hiding this comment.
nit: I'd say just move this function somewhere in the internal package, unless we want consumers to use it
| Diagnostics []*tfprotov6.Diagnostic | ||
| NewState tftypes.Value | ||
| NewIdentity *tftypes.Value | ||
| NewQuery tftypes.Value |
Member
There was a problem hiding this comment.
nit: Were these meant to be added to the create resp / delete request?
Comment on lines
+14
to
+17
| type queryCheckSpy struct { | ||
| err error | ||
| called bool | ||
| } |
Member
There was a problem hiding this comment.
nit: Doesn't look like this is used anywhere, perhaps it will eventually?
gdavison
reviewed
Sep 17, 2025
gdavison
reviewed
Sep 17, 2025
gdavison
reviewed
Sep 17, 2025
ansgarm
approved these changes
Sep 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Continues #531
Description
Adds QueryCheck to plugin testing to go along with Query
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No