Skip to content

Conversation

@gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 8, 2025

Related Issue

Related to #555

Description

Adds querycheck.ExpectNoIdentity to confirm that there is no result with the given Resource Identity

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@gdavison gdavison requested a review from a team as a code owner October 8, 2025 21:54
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gdavison, I would ask for a test but we have some work in flight to update the mock list resource we use for testing in terraform-plugin-testing so I'll omit that request for now.

Would you mind rebasing this? Once that's done this should be good to go!

@gdavison gdavison force-pushed the f-querycheck-negative-checks branch from cb22fd1 to 71ab7e0 Compare October 10, 2025 23:41
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧁

@stephybun stephybun merged commit f652157 into hashicorp:main Oct 13, 2025
3 checks passed
@gdavison gdavison deleted the f-querycheck-negative-checks branch October 14, 2025 15:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants