query: add support for ExpectError
#561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephybun
commented
Oct 10, 2025
| "github.com/hashicorp/terraform-plugin-testing/tfversion" | ||
| ) | ||
|
|
||
| func dessertsThatStartWithPResource() testprovider.Resource { |
Member
Author
There was a problem hiding this comment.
These are just some silly examples to allow the addition of two simple tests to validate the changes here, they are by no means complete and intentionally minimal since there's currently work in flight over in #553 to refactor and flesh out all of the remaining tests for query checks.
austinvalle
approved these changes
Oct 10, 2025
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Looks good to me, nice examples! 🍨
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #556
Description
testing_new.goto handleExpectErrorlike other testing modes doquerycheck.Containsone that validates the regular nonExpectErrorpath still works and one to validate thatExpectErrorworksRollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Nerp