Add PostApplyFunc to plan/apply testing
#566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
approved these changes
Oct 15, 2025
Member
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
LGTM, just one comment to consider!
|
|
||
| // PostApplyFunc is called after the Config is applied and after all plan/apply checks are run. | ||
| // This can be used to perform assertions against API values that are not stored in Terraform state. | ||
| PostApplyFunc func() |
Member
There was a problem hiding this comment.
I don't have a specific qualm about the signature, but if you haven't already, might be worth confirming with interested provider developers if there is anything they'd expect to be in a request/response, since we can't add anything without a breaking change. For example, some of these hooks have error returns for the test framework to handle, do they need any more context/data in the request, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
PostApplyFunctest step hook for plan/apply testing. This hook will run after the config is applied and after plan/apply test checks are run. This is useful for testing values that are not stored in Terraform state or testing Terraform Actions.Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
N/A