Skip to content

Commit 0f6bd80

Browse files
authored
Merge pull request #44408 from subham-ibmhc/f-ri-sfn
Add ARN based resource identity to SFN resources
2 parents f46cd9a + 1a15fff commit 0f6bd80

File tree

17 files changed

+1409
-22
lines changed

17 files changed

+1409
-22
lines changed

.changelog/44408.txt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
```release-note:enhancement
2+
resource/aws_sfn_activity: Add resource identity support
3+
```
4+
```release-note:enhancement
5+
resource/aws_sfn_activity: Add `arn` argument
6+
```
7+
```release-note:enhancement
8+
resource/aws_sfn_alias: Add resource identity support
9+
```

internal/service/sfn/activity.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,20 @@ import (
2727

2828
// @SDKResource("aws_sfn_activity", name="Activity")
2929
// @Tags(identifierAttribute="id")
30+
// @ArnIdentity
31+
// @Testing(preIdentityVersion="v6.14.1")
3032
func resourceActivity() *schema.Resource {
3133
return &schema.Resource{
3234
CreateWithoutTimeout: resourceActivityCreate,
3335
ReadWithoutTimeout: resourceActivityRead,
3436
UpdateWithoutTimeout: resourceActivityUpdate,
3537
DeleteWithoutTimeout: resourceActivityDelete,
3638

37-
Importer: &schema.ResourceImporter{
38-
StateContext: schema.ImportStatePassthroughContext,
39-
},
40-
4139
Schema: map[string]*schema.Schema{
40+
names.AttrARN: {
41+
Type: schema.TypeString,
42+
Computed: true,
43+
},
4244
names.AttrCreationDate: {
4345
Type: schema.TypeString,
4446
Computed: true,
@@ -129,6 +131,7 @@ func resourceActivityRead(ctx context.Context, d *schema.ResourceData, meta any)
129131
} else {
130132
d.Set(names.AttrEncryptionConfiguration, nil)
131133
}
134+
d.Set(names.AttrARN, output.ActivityArn)
132135
d.Set(names.AttrName, output.Name)
133136

134137
return diags

internal/service/sfn/activity_identity_gen_test.go

Lines changed: 337 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)