Skip to content

Commit f46cd9a

Browse files
Add parameterized resource identity to aws_connect_instance (#44346)
* r/aws_connect_instance: add resource identity ➜ terraform-provider-aws (main) ✗ make testacc PKG=connect TESTS=TestAccConnectInstance_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 main 🌿... TF_ACC=1 go1.24.6 test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectInstance_' -timeout 360m -vet=off 2025/09/17 14:10:15 Creating Terraform AWS Provider (SDKv2-style)... 2025/09/17 14:10:15 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccConnectInstance_Identity_Basic === PAUSE TestAccConnectInstance_Identity_Basic === RUN TestAccConnectInstance_Identity_RegionOverride === PAUSE TestAccConnectInstance_Identity_RegionOverride === RUN TestAccConnectInstance_Identity_ExistingResource === PAUSE TestAccConnectInstance_Identity_ExistingResource === CONT TestAccConnectInstance_Identity_Basic === CONT TestAccConnectInstance_Identity_ExistingResource === CONT TestAccConnectInstance_Identity_RegionOverride --- PASS: TestAccConnectInstance_Identity_RegionOverride (139.71s) --- PASS: TestAccConnectInstance_Identity_Basic (146.75s) --- PASS: TestAccConnectInstance_Identity_ExistingResource (165.09s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/connect 169.730s * Update import documentation * Add changelog * Updated for v6.14.0
1 parent c242a3d commit f46cd9a

File tree

10 files changed

+443
-10
lines changed

10 files changed

+443
-10
lines changed

.changelog/44346.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
resource/aws_connect_instance: Add resource identity support
3+
```

internal/service/connect/connect_test.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,15 @@ func TestAccConnect_serial(t *testing.T) {
5454
"dataSource_name": testAccHoursOfOperationDataSource_name,
5555
},
5656
"Instance": {
57-
acctest.CtBasic: testAccInstance_basic,
58-
"directory": testAccInstance_directory,
59-
"saml": testAccInstance_saml,
60-
"dataSource_basic": testAccInstanceDataSource_basic,
61-
"tags": testAccInstance_tags,
57+
acctest.CtBasic: testAccInstance_basic,
58+
"directory": testAccInstance_directory,
59+
"saml": testAccInstance_saml,
60+
"dataSource_basic": testAccInstanceDataSource_basic,
61+
"tags": testAccInstance_tags,
62+
"identityBasic": testAccConnectInstance_Identity_Basic,
63+
"identityExistingResource": testAccConnectInstance_Identity_ExistingResource,
64+
"identityExistingResourceNoRefresh": testAccConnectInstance_Identity_ExistingResource_NoRefresh_NoChange,
65+
"identityRegionOverride": testAccConnectInstance_Identity_RegionOverride,
6266
},
6367
"InstanceStorageConfig": {
6468
acctest.CtBasic: testAccInstanceStorageConfig_basic,

internal/service/connect/instance.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,17 @@ var (
4545

4646
// @SDKResource("aws_connect_instance", name="Instance")
4747
// @Tags(identifierAttribute="arn")
48+
// @IdentityAttribute("id")
49+
// @Testing(preIdentityVersion="6.14.1")
50+
// @Testing(serialize=true)
51+
// @Testing(existsType="github.com/aws/aws-sdk-go-v2/service/connect/types;types.Instance")
4852
func resourceInstance() *schema.Resource {
4953
return &schema.Resource{
5054
CreateWithoutTimeout: resourceInstanceCreate,
5155
ReadWithoutTimeout: resourceInstanceRead,
5256
UpdateWithoutTimeout: resourceInstanceUpdate,
5357
DeleteWithoutTimeout: resourceInstanceDelete,
5458

55-
Importer: &schema.ResourceImporter{
56-
StateContext: schema.ImportStatePassthroughContext,
57-
},
58-
5959
Timeouts: &schema.ResourceTimeout{
6060
Create: schema.DefaultTimeout(5 * time.Minute),
6161
Delete: schema.DefaultTimeout(5 * time.Minute),

internal/service/connect/instance_identity_gen_test.go

Lines changed: 321 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/service/connect/service_package_gen.go

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# Copyright (c) HashiCorp, Inc.
2+
# SPDX-License-Identifier: MPL-2.0
3+
4+
resource "aws_connect_instance" "test" {
5+
identity_management_type = "CONNECT_MANAGED"
6+
inbound_calls_enabled = true
7+
instance_alias = var.rName
8+
outbound_calls_enabled = true
9+
}
10+
11+
12+
variable "rName" {
13+
description = "Name for resource"
14+
type = string
15+
nullable = false
16+
}

0 commit comments

Comments
 (0)