Skip to content

Commit 390a640

Browse files
committed
r/aws_servicecatalog_portfolio_share: revert additional not found check on read
```console % AWS_ALTERNATE_PROFILE=terraform_team1_dev make t K=servicecatalog T=TestAccServiceCatalog_serial/PortfolioShare make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 b-aws_servicecatalog_portfolio_share-sequential-processing 🌿... TF_ACC=1 go1.24.8 test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalog_serial/PortfolioShare' -timeout 360m -vet=off 2025/10/08 15:23:23 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/08 15:23:23 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccServiceCatalog_serial (216.76s) --- PASS: TestAccServiceCatalog_serial/PortfolioShare (216.76s) --- PASS: TestAccServiceCatalog_serial/PortfolioShare/basic (39.02s) --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/sharePrincipals (0.54s) --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/organizationalUnit (0.38s) --- PASS: TestAccServiceCatalog_serial/PortfolioShare/disappears (176.83s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog 223.513s ```
1 parent 4df5b34 commit 390a640

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/service/servicecatalog/portfolio_share.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ func resourcePortfolioShareRead(ctx context.Context, d *schema.ResourceData, met
199199

200200
output, err := waitPortfolioShareReady(ctx, conn, portfolioID, shareType, principalID, waitForAcceptance, d.Timeout(schema.TimeoutRead))
201201

202-
if !d.IsNewResource() && (errs.IsA[*awstypes.ResourceNotFoundException](err) || tfresource.NotFound(err)) {
202+
if !d.IsNewResource() && tfresource.NotFound(err) {
203203
log.Printf("[WARN] Service Catalog Portfolio Share (%s) not found, removing from state", d.Id())
204204
d.SetId("")
205205
return diags

0 commit comments

Comments
 (0)