Skip to content

Conversation

kamilturek
Copy link
Collaborator

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

N/A

Description

This PR updates the DynamoDB retries to not retry on LimitExceededException indicating the MaxReadRequestUnits and TableMaxWriteCapacityUnits limits.

Closes #44217.

References

N/A

Output from Acceptance Testing

$ make testacc TESTS=TestAccDynamoDBTable_basic PKG=dynamodb     
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-aws_dynamodb_table-limit-exceeded-exception-infinite-retries 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_basic'  -timeout 360m -vet=off
2025/10/07 23:46:06 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/07 23:46:06 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDynamoDBTable_basic
=== PAUSE TestAccDynamoDBTable_basic
=== CONT  TestAccDynamoDBTable_basic
--- PASS: TestAccDynamoDBTable_basic (34.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   39.497s

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XS Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Oct 7, 2025
@kamilturek kamilturek marked this pull request as ready for review October 8, 2025 07:00
@kamilturek kamilturek requested a review from a team as a code owner October 8, 2025 07:00
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 8, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6749964 into hashicorp:main Oct 8, 2025
34 checks passed
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.16.0 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-maintainer Contribution from a trusted external contributor. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB table creation hangs at "still creating" when exceeding account-level MaxThroughput
2 participants