Skip to content

Conversation

@stijndehaes
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

No changes.

Description

This fixes a bug where the blue green deployment did not have any tags attached to it since it wasn't set when creating the deployment.
In cases where IAM rights are based on resource tags this results in blue green deployments not working with the terraform provider.

Relations

None

References

Output from Acceptance Testing

I currently ran a single test TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion, which I changed
to ensure the defaults tags from the provider where used.
I inspected the RDS blue green deployment in the AWS console, since I don't know how I can automate this in a test, since after terraform apply the blue green deployment resource is gone

GOROOT=/Users/stijndehaes/go/pkg/mod/golang.org/[email protected] #gosetup
GOPATH=/Users/stijndehaes/go #gosetup
/Users/stijndehaes/go/pkg/mod/golang.org/[email protected]/bin/go test -c -o /Users/stijndehaes/Library/Caches/JetBrains/GoLand2025.2/tmp/GoLand/___TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion_in_github_com_hashicorp_terraform_provider_aws_internal_service_rds.test github.com/hashicorp/terraform-provider-aws/internal/service/rds #gosetup
/Users/stijndehaes/go/pkg/mod/golang.org/[email protected]/bin/go tool test2json -t /Users/stijndehaes/Library/Caches/JetBrains/GoLand2025.2/tmp/GoLand/___TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion_in_github_com_hashicorp_terraform_provider_aws_internal_service_rds.test -test.v=test2json -test.paniconexit0 -test.run ^\QTestAccRDSInstance_BlueGreenDeployment_updateEngineVersion\E$ #gosetup
2025/11/14 12:04:56 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/14 12:04:56 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion (1771.19s)
PASS
...

@stijndehaes stijndehaes requested a review from a team as a code owner November 14, 2025 12:23
@github-actions
Copy link
Contributor

⚠️ Our automation has detected the following potential issues with your pull request


❌ Changelog Entry Required (Click to expand)

The proposed change requires a changelog entry. Please see the Changelog Process section of the contributing guide for information on the changelog generation process.

Tip: This check is not triggered for draft pull requests, since the pull request number is not known until the pull request is opened and is required to create a changelog entry. Opening a pull request first as a draft, adding the requisite changelog entry file, and then marking the pull request as ready for review will prevent future warnings.

@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels Nov 14, 2025
@@ -14073,6 +14073,14 @@ func testAccInstanceConfig_BlueGreenDeployment_engineVersion(rName string, updat
return acctest.ConfigCompose(
acctest.ConfigRandomPassword(),
fmt.Sprintf(`
provider "aws" {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test failing because I added the provider here, for me this was the way to check if tags were added. But the process isn't automated anyway, so maybe I just remove it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant