Skip to content

[bugfix] stop recreating serverless cache if upgrading from valkey 7 to 8 #45087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+108 −4
Draft

[bugfix] stop recreating serverless cache if upgrading from valkey 7 to 8 #45087

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a9ba82
stop recreating serverless cache if upgrading from valkey 7 to 8
sukumaar Nov 14, 2025
9851a4e
upgrade only support for valkey . Enabled valkey to redis switch
sukumaar Nov 21, 2025
57596b6
added test case for valkey with major version
sukumaar Nov 21, 2025
13ed03c
Merge branch 'hashicorp:main' into f-elasticache-serverless-valkey-ve…
sukumaar Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion internal/service/elasticache/serverless_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,19 @@ func (r *serverlessCacheResource) Schema(ctx context.Context, request resource.S
Computed: true,
PlanModifiers: []planmodifier.String{
stringplanmodifier.UseStateForUnknown(),
stringplanmodifier.RequiresReplace(),
stringplanmodifier.RequiresReplaceIf(
func(ctx context.Context, req planmodifier.StringRequest, resp *stringplanmodifier.RequiresReplaceIfFuncResponse) {
// Not replacing if upgrading from 7 to 8
if req.StateValue.Equal(types.StringValue("7")) && req.PlanValue.Equal(types.StringValue("8")) {
return
}

// Any other change will force a replacement
resp.RequiresReplace = true
},
"major_engine_version change other than 7 to 8 needs replacement",
"major_engine_version change other than 7 to 8 needs replacement",
),
},
},
names.AttrName: schema.StringAttribute{
Expand Down
Loading