Skip to content

Conversation

@mevlanaayas
Copy link

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Description

Adds aws sesv2 contact resource support. Since only one contact list allowed per account, contact list tests updated relatively.

https://docs.aws.amazon.com/cli/latest/reference/sesv2/create-contact.html

Output from Acceptance Testing

% make testacc TESTS=TestAccSESV2Contact PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-sesv2-contact 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2Contact'  -timeout 360m -vet=off
2025/11/19 11:18:32 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/19 11:18:32 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSESV2Contact_serial
=== PAUSE TestAccSESV2Contact_serial
=== CONT  TestAccSESV2Contact_serial
=== RUN   TestAccSESV2Contact_serial/ContactList
=== RUN   TestAccSESV2Contact_serial/ContactList/basic
=== RUN   TestAccSESV2Contact_serial/ContactList/disappears
=== RUN   TestAccSESV2Contact_serial/ContactList/tags
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_overlapping
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_emptyResourceTag
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/ComputedTag_OnCreate
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/ComputedTag_OnUpdate_Add
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/EmptyMap
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/EmptyTag_OnCreate
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/EmptyTag_OnUpdate_Replace
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_providerOnly
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_nonOverlapping
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/ComputedTag_OnUpdate_Replace
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/basic
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/EmptyTag_OnUpdate_Add
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_updateToProviderOnly
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_updateToResourceOnly
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/null
=== RUN   TestAccSESV2Contact_serial/ContactList/tags/AddOnUpdate
=== RUN   TestAccSESV2Contact_serial/ContactList/description
=== RUN   TestAccSESV2Contact_serial/ContactList/topic
=== RUN   TestAccSESV2Contact_serial/Contact
=== RUN   TestAccSESV2Contact_serial/Contact/basic
=== RUN   TestAccSESV2Contact_serial/Contact/disappears
--- PASS: TestAccSESV2Contact_serial (1432.18s)
    --- PASS: TestAccSESV2Contact_serial/ContactList (1300.31s)
        --- PASS: TestAccSESV2Contact_serial/ContactList/basic (59.18s)
        --- PASS: TestAccSESV2Contact_serial/ContactList/disappears (23.20s)
        --- PASS: TestAccSESV2Contact_serial/ContactList/tags (1131.79s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_overlapping (75.39s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_emptyResourceTag (29.37s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/ComputedTag_OnCreate (31.17s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/ComputedTag_OnUpdate_Add (48.44s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/IgnoreTags_Overlap_ResourceTag (64.23s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/EmptyMap (43.72s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/EmptyTag_OnCreate (50.46s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/EmptyTag_OnUpdate_Replace (45.17s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_providerOnly (96.75s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/IgnoreTags_Overlap_DefaultTag (92.50s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_nonOverlapping (100.63s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_nullOverlappingResourceTag (28.87s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/ComputedTag_OnUpdate_Replace (49.83s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/basic (98.65s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/EmptyTag_OnUpdate_Add (68.33s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_updateToProviderOnly (46.17s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_updateToResourceOnly (43.97s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/DefaultTags_nullNonOverlappingResourceTag (29.06s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/null (43.11s)
            --- PASS: TestAccSESV2Contact_serial/ContactList/tags/AddOnUpdate (45.96s)
        --- PASS: TestAccSESV2Contact_serial/ContactList/description (43.27s)
        --- PASS: TestAccSESV2Contact_serial/ContactList/topic (42.89s)
    --- PASS: TestAccSESV2Contact_serial/Contact (131.87s)
        --- PASS: TestAccSESV2Contact_serial/Contact/basic (107.80s)
        --- PASS: TestAccSESV2Contact_serial/Contact/disappears (24.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      1436.971s

@mevlanaayas mevlanaayas requested a review from a team as a code owner November 19, 2025 08:43
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sesv2 Issues and PRs that pertain to the sesv2 service. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant