-
Notifications
You must be signed in to change notification settings - Fork 9.8k
test generation: Updates Resource Identity tests to use VCR-ready random string generation #45215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gdavison
wants to merge
72
commits into
main
Choose a base branch
from
td-test-gen-vcr-ready
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
generators
Relates to code generators.
service/acmpca
Issues and PRs that pertain to the acmpca service.
service/amp
Issues and PRs that pertain to the amp service.
service/appflow
Issues and PRs that pertain to the appflow service.
service/apprunner
Issues and PRs that pertain to the apprunner service.
service/batch
Issues and PRs that pertain to the batch service.
service/bcmdataexports
Issues and PRs that pertain to the bcmdataexports service.
service/bedrock
Issues and PRs that pertain to the bedrock service.
service/ce
Issues and PRs that pertain to the ce service.
service/chimesdkmediapipelines
Issues and PRs that pertain to the chimesdkmediapipelines service.
service/cleanrooms
Issues and PRs that pertain to the cleanrooms service.
service/cloudfront
Issues and PRs that pertain to the cloudfront service.
service/cloudfrontkeyvaluestore
Issues and PRs that pertain to the cloudfrontkeyvaluestore service.
service/cloudtrail
Issues and PRs that pertain to the cloudtrail service.
service/cloudwatch
Issues and PRs that pertain to the cloudwatch service.
service/codeartifact
Issues and PRs that pertain to the codeartifact service.
service/codebuild
Issues and PRs that pertain to the codebuild service.
service/codeconnections
Issues and PRs that pertain to the codeconnections service.
service/codegurureviewer
Issues and PRs that pertain to the codegurureviewer service.
service/codepipeline
Issues and PRs that pertain to the codepipeline service.
service/codestarconnections
Issues and PRs that pertain to the codestarconnections service.
service/codestarnotifications
Issues and PRs that pertain to the codestarnotifications service.
service/cognitoidp
Issues and PRs that pertain to the cognitoidp service.
service/comprehend
Issues and PRs that pertain to the comprehend service.
service/connect
Issues and PRs that pertain to the connect service.
service/datasync
Issues and PRs that pertain to the datasync service.
service/devicefarm
Issues and PRs that pertain to the devicefarm service.
service/dms
Issues and PRs that pertain to the dms service.
service/docdbelastic
Issues and PRs that pertain to the docdbelastic service.
service/dynamodb
Issues and PRs that pertain to the dynamodb service.
service/ecr
Issues and PRs that pertain to the ecr service.
service/ecs
Issues and PRs that pertain to the ecs service.
service/elbv2
Issues and PRs that pertain to the elbv2 service.
service/events
Issues and PRs that pertain to the events service.
service/globalaccelerator
Issues and PRs that pertain to the globalaccelerator service.
service/glue
Issues and PRs that pertain to the glue service.
service/iam
Issues and PRs that pertain to the iam service.
service/imagebuilder
Issues and PRs that pertain to the imagebuilder service.
service/inspector
Issues and PRs that pertain to the inspector service.
service/inspector2
Issues and PRs that pertain to the inspector2 service.
service/iot
Issues and PRs that pertain to the iot service.
service/ivs
Issues and PRs that pertain to the ivs service.
service/ivschat
Issues and PRs that pertain to the ivschat service.
service/kinesis
Issues and PRs that pertain to the kinesis service.
service/kms
Issues and PRs that pertain to the kms service.
service/lambda
Issues and PRs that pertain to the lambda service.
service/logs
Issues and PRs that pertain to the logs service.
service/networkfirewall
Issues and PRs that pertain to the networkfirewall service.
service/organizations
Issues and PRs that pertain to the organizations service.
service/rds
Issues and PRs that pertain to the rds service.
service/redshift
Issues and PRs that pertain to the redshift service.
service/resourceexplorer2
Issues and PRs that pertain to the resourceexplorer2 service.
service/route53resolver
Issues and PRs that pertain to the route53resolver service.
service/s3control
Issues and PRs that pertain to the s3control service.
service/s3tables
Issues and PRs that pertain to the s3tables service.
service/s3
Issues and PRs that pertain to the s3 service.
service/sagemaker
Issues and PRs that pertain to the sagemaker service.
service/secretsmanager
Issues and PRs that pertain to the secretsmanager service.
service/securityhub
Issues and PRs that pertain to the securityhub service.
service/sfn
Issues and PRs that pertain to the sfn service.
service/shield
Issues and PRs that pertain to the shield service.
service/sns
Issues and PRs that pertain to the sns service.
service/sqs
Issues and PRs that pertain to the sqs service.
service/ssm
Issues and PRs that pertain to the ssm service.
service/ssmcontacts
Issues and PRs that pertain to the ssmcontacts service.
service/ssoadmin
Issues and PRs that pertain to the ssoadmin service.
service/vpc
Issues and PRs that pertain to the vpc service.
service/xray
Issues and PRs that pertain to the xray service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Updates Resource Identity tests to use VCR-ready random string generation function
acctest.RandomWithPrefix