Skip to content

Comments

r/aws_lambda_function(test): update expected source code hash values#46614

Merged
jar-b merged 1 commit intomainfrom
td-lambda-localupdate
Feb 23, 2026
Merged

r/aws_lambda_function(test): update expected source code hash values#46614
jar-b merged 1 commit intomainfrom
td-lambda-localupdate

Conversation

@jar-b
Copy link
Member

@jar-b jar-b commented Feb 23, 2026

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Following the addition of copyright headers to the test fixtures used in various Lambda function acceptance tests, the expected source code hash values all required an update.

Relations

Closes #46561

Output from Acceptance Testing

% make t K=lambda T="TestAccLambdaFunction_LocalUpdate_|TestAccLambdaFunction_S3Update_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 td-lambda-localupdate 🌿...
TF_ACC=1 go1.25.7 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunction_LocalUpdate_|TestAccLambdaFunction_S3Update_'  -timeout 360m -vet=off
2026/02/23 10:27:55 Creating Terraform AWS Provider (SDKv2-style)...
2026/02/23 10:27:56 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccLambdaFunction_S3Update_unversioned (60.88s)
--- PASS: TestAccLambdaFunction_S3Update_basic (62.98s)
--- PASS: TestAccLambdaFunction_LocalUpdate_publish (123.84s)
--- PASS: TestAccLambdaFunction_LocalUpdate_nameOnly (129.55s)
--- PASS: TestAccLambdaFunction_LocalUpdate_sourceCodeHash (135.52s)
--- PASS: TestAccLambdaFunction_LocalUpdate_sourceCodeHashToCodeSha256 (141.51s)
--- PASS: TestAccLambdaFunction_LocalUpdate_codeSha256 (147.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     154.672s

Following the addition of copyright headers to the test fixtures used in various Lambda function acceptance tests, the expected source code hash values all required an update.

```console
% make t K=lambda T="TestAccLambdaFunction_LocalUpdate_|TestAccLambdaFunction_S3Update_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 td-lambda-localupdate 🌿...
TF_ACC=1 go1.25.7 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunction_LocalUpdate_|TestAccLambdaFunction_S3Update_'  -timeout 360m -vet=off
2026/02/23 10:27:55 Creating Terraform AWS Provider (SDKv2-style)...
2026/02/23 10:27:56 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccLambdaFunction_S3Update_unversioned (60.88s)
--- PASS: TestAccLambdaFunction_S3Update_basic (62.98s)
--- PASS: TestAccLambdaFunction_LocalUpdate_publish (123.84s)
--- PASS: TestAccLambdaFunction_LocalUpdate_nameOnly (129.55s)
--- PASS: TestAccLambdaFunction_LocalUpdate_sourceCodeHash (135.52s)
--- PASS: TestAccLambdaFunction_LocalUpdate_sourceCodeHashToCodeSha256 (141.51s)
--- PASS: TestAccLambdaFunction_LocalUpdate_codeSha256 (147.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     154.672s
```
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. size/S Managed by automation to categorize the size of a PR. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 23, 2026
@jar-b jar-b marked this pull request as ready for review February 23, 2026 15:59
@jar-b jar-b requested a review from a team as a code owner February 23, 2026 15:59
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, LGTM 🎉

@jar-b jar-b merged commit ca9273d into main Feb 23, 2026
66 checks passed
@jar-b jar-b deleted the td-lambda-localupdate branch February 23, 2026 18:22
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.34.0 milestone Feb 23, 2026
terraform-aws-provider bot pushed a commit that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service/lambda Issues and PRs that pertain to the lambda service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

r/aws_lambda_function: _LocalUpdate tests failing

2 participants