Fix: Provider produced inconsistent result after apply

[parisholley]

I ran into this issue when trying to create a lex bot: #619

Looking through the issue log, I suspect there are a lot of open issues that have the same problem:

• Error: Provider produced inconsistent result after apply - awscc_lex_bot #1449
• awscc_dms_migration_project Provider produced inconsistent result after apply #1635
• awscc_ecs_task_definition : Provider produced inconsistent result after apply #1586
• awscc_cloudformation_stack_set: Resource doesn't work with StackInstancesGroup attribute #1451

My solution addresses two things:

1. WriteOnly fields should not be marked as "compute: true", otherwise TF will attempt to compare the CloudControl response (which doesn't have the property) to the DesiredState
2. WriteOnly (and other flags) need to cascade down to child properties, in my case, bot_locale was compute = false, but because some of the properties beneath were marked as compute = true, the error still exists

For anyone wanting to try this, I have published my fork with this fix:

https://registry.terraform.io/providers/parisholley/awscc/latest

As a note, I am curious if this fix maybe negates the need for this previous PR:

#1737

[parisholley]

here are the two changes given that most of the touched files are from make resources

terraform-provider-awscc/internal/provider/generators/shared/codegen/emitter.go

Lines 123 to 147 in e814ac4

	createOnly := false
	readOnly := false
	writeOnly := false
	var chunks [][]string
	// Build combinations
	for i := 1; i <= len(path); i++ {
	combination := path[:i]
	chunks = append(chunks, combination)
	}
	for i := 0; i < len(chunks); i++ {
	if e.CfResource.CreateOnlyProperties.ContainsPath(chunks[i]) {
	createOnly = true
	}
	if e.CfResource.ReadOnlyProperties.ContainsPath(chunks[i]) {
	readOnly = true
	}
	if e.CfResource.WriteOnlyProperties.ContainsPath(chunks[i]) {
	writeOnly = true
	}
	}

terraform-provider-awscc/internal/provider/generators/shared/codegen/emitter.go

Lines 182 to 184 in e814ac4

	if optional && !computed && !writeOnly {
	computed = true
	}

[Krata4]

Hello, are you planning to do marge please?

[sgalloway-earnest]

Hi, I encountered this issue with "awscc_cognito_managed_login_branding", the provider fails at apply for any changes, because it is trying to provide the client_id which is a write-only computed property.

@parisholley is the PR still active?