applications: retry on 409 after creating application

[brian-sqq]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

We recently started experiencing the issue reported at #1764. We have engaged Azure Support and I've posted their response in a comment on the issue..

This is my first contribution to this project, and given the simplicity of it, I am hopeful that a maintainer or regular contributor will test it. I am able to build, but of course the change is quite small. Since the provider is depending on the SDK for handling other retry-able errors, I'm hopeful we can add the 409 -- admittedly, I have not interrogated the SDK.

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azuread_application - retry in case of 409 conflict, resolves issue 1764

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #1764

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[brian-sqq]

We have built and published this to our Terraform Cloud private repository, and used it several times with success. We will continue to use our fork until this is merged, but ask that a maintainer please review and merge this so we can get back to the main-line.

[jackofallops]

Hi @brian-sqq - We don't review PRs in WIP, if this is ready for maintainer review, can you mark it as ready?

[brian-sqq]

Hi @brian-sqq - We don't review PRs in WIP, if this is ready for maintainer review, can you mark it as ready?

Thanks @jackofallops, I've done so. We've been running this in production since mid-September. We'll be happy for it to be merged here so we can upgrade and stop using our fork.

[jackofallops]

Hi @brian-sqq - Thanks for this. Since it's something of an anti-pattern, can you take a look at including the extra context in the comment suggestions below to assist future contributions for this resoruce?

Thanks

[jackofallops]

Tests passing 👍

[jackofallops]

Hi @brian-sqq - Thanks for the changes, this LGTM now 👍