Skip to content

Feat/graph proxy endpoint#1838

Open
vimal-vijayan wants to merge 2 commits intohashicorp:mainfrom
vimal-vijayan:feat/graph-proxy-endpoint
Open

Feat/graph proxy endpoint#1838
vimal-vijayan wants to merge 2 commits intohashicorp:mainfrom
vimal-vijayan:feat/graph-proxy-endpoint

Conversation

@vimal-vijayan
Copy link

Description

This PR adds support for overriding Microsoft Graph settings in the AzureAD provider to support proxy/custom Graph deployments.

Changes included:

  • Adds new provider arguments:
    • microsoft_graph_endpoint (env: ARM_MS_GRAPH_ENDPOINT)
    • microsoft_graph_resource_id (env: ARM_MS_GRAPH_RESOURCE_ID)
  • Trims trailing / from microsoft_graph_endpoint for consistent behavior.
  • Preserves the Microsoft Graph App ID when endpoint/resource overrides are applied.
  • Adds validation and existing safety checks to ensure Graph endpoint resolution remains valid.
  • Updates provider docs for the new arguments.
  • Adds acceptance tests for:
    • endpoint-only override
    • endpoint + resource ID override

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them.
  • I have written new tests for my changes & updated relevant documentation.
  • I have successfully run tests with my changes locally. (update this checkbox based on your run)
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • Added:
    • TestAccProvider_graphEndpointOverride
    • TestAccProvider_graphEndpointAndResourceIdOverride

Example local run command:

TF_ACC=1 go test ./internal/provider -run 'TestAccProvider_graphEndpointOverride|TestAccProvider_graphEndpointAndResourceIdOverride'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant