Add a post-promotion workflow to promote-staging #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Pausing for a moment to 💭 through this. This will not work as written. At pre-promotion time for Right now, the value is in safely exercising the upload workflow, so I think it's fine to do move this from pre- to post-promotion to get that feedback. We're in the safety net 😃 I would not do that for |
bbasata
changed the title
... because upload currently expects to download artifacts from the staging repo.
rainkwan
force-pushed
the
pre-promotion-workflow
branch
from
cd3535f to
e23c3b3
Compare
austinvalle
approved these changes
Mar 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step in testing Registry manifest upload.
Ultimately, we want a pre-promotion workflow for promote-production. That workflow is in an internal repo as a pre-promotion workflow. It will upload the manifest to the staging Releases site -- not production.
For testing within a safety net, this PR configures a post-promotion workflow for
promote-staging, becausepromote-stagingis responsible for promoting artifacts to the the staging artifacts repo.