Skip to content

framework6provider: set identity in StateMover #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged

framework6provider: set identity in StateMover #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e4e678
framework6provider: set identity in StateMover
bbasata Jul 29, 2025
1c91ca9
tidy
bbasata Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/framework5provider/move_state_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ func (r MoveStateResource) MoveState(ctx context.Context) []resource.StateMover
}

resp.Diagnostics.Append(resp.TargetState.SetAttribute(ctx, path.Root("moved_random_string"), oldState.Result)...)
resp.Diagnostics.Append(resp.TargetIdentity.SetAttribute(ctx, path.Root("id"), oldState.Result)...)
case "registry.terraform.io/hashicorp/framework": // Corner provider (testing identity moves)
if req.SourceTypeName != "framework_identity" {
resp.Diagnostics.AddError(
Expand Down
2 changes: 0 additions & 2 deletions internal/framework5provider/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ package framework

import (
"context"
"fmt"

"github.com/hashicorp/terraform-plugin-framework/datasource"
"github.com/hashicorp/terraform-plugin-framework/ephemeral"
Expand Down Expand Up @@ -149,7 +148,6 @@ func (p *testProvider) EphemeralResources(ctx context.Context) []func() ephemera
}

func (p *testProvider) ListResources(_ context.Context) []func() list.ListResource {
fmt.Println("ListResources called")
return []func() list.ListResource{
NewListResourceAsListResource,
}
Expand Down
1 change: 1 addition & 0 deletions internal/framework6provider/move_state_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ func (r MoveStateResource) MoveState(ctx context.Context) []resource.StateMover
}

resp.Diagnostics.Append(resp.TargetState.SetAttribute(ctx, path.Root("moved_random_string"), oldState.Result)...)
resp.Diagnostics.Append(resp.TargetIdentity.SetAttribute(ctx, path.Root("id"), oldState.Result)...)
case "registry.terraform.io/hashicorp/framework": // Corner provider (testing identity moves)
if req.SourceTypeName != "framework_identity" {
resp.Diagnostics.AddError(
Expand Down
Loading