Skip to content

Conversation

@SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Sep 15, 2025

@SBGoods SBGoods requested a review from a team as a code owner September 15, 2025 21:55
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I think you're already pursuing this, but posting a working run of this test suite locally would be worth it since our CI is still using the old published version

)

func TestUnlinkedAction(t *testing.T) {
func TestModifyFileAction(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit 🦸🏻 - The comment in here (and the framework6provider) references unlinked 👀

Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you commented that this has run locally already, so I'm gonna stamped a ✅ so you're not blocked

@austinvalle austinvalle merged commit e3996cf into main Sep 17, 2025
208 of 220 checks passed
@austinvalle austinvalle deleted the SBGoods/simplify-actions branch September 17, 2025 11:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants