Skip to content

framework: Fix MoveResourceState tests #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 22, 2025
+14 −0
Merged

framework: Fix MoveResourceState tests #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7011729
fix tests + update dependencies
austinvalle Sep 22, 2025
d5519fd
fix tests + update dependencies
austinvalle Sep 22, 2025
01c8dbd
Merge branch 'av/identity-test-fixes' of github.com:hashicorp/terrafo…
austinvalle Sep 22, 2025
7cc14dc
temp commit for CI to show tests passing
austinvalle Sep 22, 2025
7bb225d
Revert "temp commit for CI to show tests passing"
austinvalle Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/framework5provider/move_state_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ func (r MoveStateResource) Read(ctx context.Context, req resource.ReadRequest, r
return
}

// Unlike normal resources, this resource can't produce it's identity during read, but it's the same value
Copy link
Contributor

@rainkwan rainkwan Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I understand this comment but it does feel a little like a pronoun game

// as the state value, so we can just use that to prevent any pass-through errors for versions of Terraform
// that don't support identity.
if req.Identity.Raw.IsNull() {
resp.Diagnostics.Append(resp.Identity.SetAttribute(ctx, path.Root("id"), data.MovedRandomString)...)
}

resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
}

Expand Down
7 changes: 7 additions & 0 deletions internal/framework6provider/move_state_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ func (r MoveStateResource) Read(ctx context.Context, req resource.ReadRequest, r
return
}

// Unlike normal resources, this resource can't produce it's identity during read, but it's the same value
// as the state value, so we can just use that to prevent any pass-through errors for versions of Terraform
// that don't support identity.
if req.Identity.Raw.IsNull() {
resp.Diagnostics.Append(resp.Identity.SetAttribute(ctx, path.Root("id"), data.MovedRandomString)...)
}

resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
}

Expand Down
Loading