Use DynamicAttribute for query attribute #367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
simonhammes
commented
Oct 20, 2024
| ID types.String `tfsdk:"id"` | ||
| Program types.List `tfsdk:"program"` | ||
| WorkingDir types.String `tfsdk:"working_dir"` | ||
| Query types.Dynamic `tfsdk:"query"` |
Author
There was a problem hiding this comment.
Is this a breaking change?
I tried to look up how Terraform handles schema changes, but the schema definition for data sources does not include the version field..
simonhammes
commented
Oct 20, 2024
| return result, nil | ||
| } | ||
|
|
||
| func marshalAttrValueToJSON(val attr.Value) ([]byte, error) { |
Author
There was a problem hiding this comment.
Is there some built-in way to serialize an attr.Value into JSON?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2