Add option to set autoresize limit (#4743) (#3273)

Co-authored-by: Evy Bongers <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Evy Bongers <[email protected]>

Author: modular-magician

.changelog/4743.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+sql: added field `disk_autoresize_limit` to `sql_database_instance`
+```

google-beta/resource_dataproc_cluster_test.go

@@ -13,8 +13,9 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 
-	dataproc "google.golang.org/api/dataproc/v1beta2"
 	"google.golang.org/api/googleapi"
+
+	dataproc "google.golang.org/api/dataproc/v1beta2"
 )
 
 func TestDataprocExtractInitTimeout(t *testing.T) {

google-beta/resource_sql_database_instance.go

@@ -270,6 +270,13 @@ settings.backup_configuration.binary_log_enabled are both set to true.`,
 							DiffSuppressFunc: suppressFirstGen,
 							Description:      `Configuration to increase storage size automatically.  Note that future terraform apply calls will attempt to resize the disk to the value specified in disk_size - if this is set, do not set disk_size.`,
 						},
+						"disk_autoresize_limit": {
+							Type:             schema.TypeInt,
+							Optional:         true,
+							Default:          0,
+							DiffSuppressFunc: suppressFirstGen,
+							Description:      `The maximum size, in GB, to which storage capacity can be automatically increased. The default value is 0, which specifies that there is no limit.`,
+						},
 						"disk_size": {
 							Type:     schema.TypeInt,
 							Optional: true,
@@ -978,6 +985,7 @@ func expandSqlDatabaseInstanceSettings(configured []interface{}, secondGen bool)
 	if secondGen {
 		resize := _settings["disk_autoresize"].(bool)
 		settings.StorageAutoResize = &resize
+		settings.StorageAutoResizeLimit = int64(_settings["disk_autoresize_limit"].(int))
 	}
 
 	return settings
@@ -1395,6 +1403,7 @@ func flattenSettings(settings *sqladmin.Settings) []map[string]interface{} {
 	}
 
 	data["disk_autoresize"] = settings.StorageAutoResize
+	data["disk_autoresize_limit"] = settings.StorageAutoResizeLimit
 
 	if settings.UserLabels != nil {
 		data["user_labels"] = settings.UserLabels

google-beta/resource_sql_database_instance_test.go

@@ -1253,10 +1253,11 @@ resource "google_sql_database_instance" "instance" {
   deletion_protection = false
 
   settings {
-    tier            = "db-f1-micro"
-    disk_autoresize = true
-    disk_size       = 15
-    disk_type       = "PD_HDD"
+    tier                  = "db-f1-micro"
+    disk_autoresize       = true
+    disk_autoresize_limit = 50
+    disk_size             = 15
+    disk_type             = "PD_HDD"
   }
 }
 `

website/docs/d/sql_database_instance.html.markdown

@@ -68,6 +68,8 @@ instance, high availability (`REGIONAL`) or single zone (`ZONAL`).
 
 * `disk_autoresize` - Configuration to increase storage size automatically.
 
+* `disk_autoresize_limit` - The maximum size, in GB, to which storage capacity can be automatically increased.
+
 * `disk_size` - The size of data disk, in GB.
 
 * `disk_type` - The type of data disk.