don't output JSON credentials to console when malformed (#5995) (#4266)

modular-magician · megan07 · commit c304dd2b4c43 · 2022-04-29T14:44:09.000-05:00
* don't output JSON credentials to console when malformed

* remove creds too

Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/5995.txt b/.changelog/5995.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+provider: removed printing credentials to the console if malformed JSON is given
+```
diff --git a/google-beta/provider.go b/google-beta/provider.go
@@ -1708,7 +1708,7 @@ func validateCredentials(v interface{}, k string) (warnings []string, errors []e
 	}
 	if _, err := googleoauth.CredentialsFromJSON(context.Background(), []byte(creds)); err != nil {
 		errors = append(errors,
-			fmt.Errorf("JSON credentials in %q are not valid: %s", creds, err))
+			fmt.Errorf("JSON credentials are not valid: %s", err))
 	}
 
 	return

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:bug
	`2`	`+provider: removed printing credentials to the console if malformed JSON is given`
	`3`	+```
Original file line number	Diff line number	Diff line change
`@@ -1708,7 +1708,7 @@ func validateCredentials(v interface{}, k string) (warnings []string, errors []e`
`1708`	`1708`	`}`
`1709`	`1709`	`if _, err := googleoauth.CredentialsFromJSON(context.Background(), []byte(creds)); err != nil {`
`1710`	`1710`	`errors = append(errors,`
`1711`		`- fmt.Errorf("JSON credentials in %q are not valid: %s", creds, err))`
	`1711`	`+ fmt.Errorf("JSON credentials are not valid: %s", err))`
`1712`	`1712`	`}`
`1713`	`1713`
`1714`	`1714`	`return`