Skip to content

add new fields and update examples#10863

Merged
modular-magician merged 1 commit intohashicorp:mainfrom
modular-magician:downstream-pr-e3b1f3221f41a6912e8e7dee901ce48268ec775d
Oct 10, 2025
Merged

add new fields and update examples#10863
modular-magician merged 1 commit intohashicorp:mainfrom
modular-magician:downstream-pr-e3b1f3221f41a6912e8e7dee901ce48268ec775d

Conversation

@modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Oct 10, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

discoveryengine: added `connector_modes`, `sync_mode`, `incremental_refresh_interval`, `auto_run_disabled`, and `incremental_sync_disabled` fields to `google_discovery_engine_data_connector` resource

discoveryengine: added `kms_key_name` field to `google_discovery_engine_search_engine` resource

discoveryengine: fixed bug where it wasn't possible to specify values for `knowledgeBaseSysId` or `catalogSysId` in `google_discovery_engine_data_connector.entities.params`.

discoveryengine: changed type of `google_discovery_engine_data_connector.entities.params`. Previously, it was a map of string keys to string values; now, it must be a [JSON-encoded](https://developer.hashicorp.com/terraform/language/functions/jsonencode) string containing an object. This change is being made in a minor release because the field wasn't usable as intended – specifically, all current valid uses require mapping strings to _lists_ of strings.

Derived from GoogleCloudPlatform/magic-modules#15296

@modular-magician
add new fields and update examples (#15296)
2816f00 
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

[upstream:e3b1f3221f41a6912e8e7dee901ce48268ec775d]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit d3562ff into hashicorp:main Oct 10, 2025
4 checks passed
melinath pushed a commit that referenced this pull request Oct 10, 2025
@modular-magician @melinath
add new fields and update examples (#15296) (#10863)
91e3e6a 
[upstream:e3b1f3221f41a6912e8e7dee901ce48268ec775d]

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c2thorn c2thorn Awaiting requested review from c2thorn c2thorn is a code owner

@hao-nan-li hao-nan-li Awaiting requested review from hao-nan-li hao-nan-li is a code owner

@melinath melinath Awaiting requested review from melinath melinath is a code owner

@NickElliot NickElliot Awaiting requested review from NickElliot NickElliot is a code owner

@rileykarson rileykarson Awaiting requested review from rileykarson rileykarson is a code owner

@roaks3 roaks3 Awaiting requested review from roaks3 roaks3 is a code owner

@ScottSuarez ScottSuarez Awaiting requested review from ScottSuarez ScottSuarez is a code owner

@shuyama1 shuyama1 Awaiting requested review from shuyama1 shuyama1 is a code owner

@SirGitsalot SirGitsalot Awaiting requested review from SirGitsalot SirGitsalot is a code owner

@slevenick slevenick Awaiting requested review from slevenick slevenick is a code owner

@trodge trodge Awaiting requested review from trodge trodge is a code owner

@zli82016 zli82016 Awaiting requested review from zli82016 zli82016 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@modular-magician